Adds Getter for floatingActionButtonLocation in ScaffoldState #148082
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
Piinks
reviewed
May 15, 2024
There was a problem hiding this comment.
Hey @piedcipher thanks for sending a PR! I don't know that we need to add this though. The FAB location has a clear default, unless the user provides another value. I don't know that we need to expose it on the ScaffoldState.
WDYT about waiting to see if we get more feedback on the issue that indicates there is a need for this?
| @@ -2136,6 +2136,11 @@ class ScaffoldState extends State<Scaffold> with TickerProviderStateMixin, Resto | |||
| final RestorableBool _drawerOpened = RestorableBool(false); | |||
| final RestorableBool _endDrawerOpened = RestorableBool(false); | |||
|
|
|||
| /// The current position of [FloatingActionButton] in [Scaffold]. | |||
| /// | |||
| /// defaults to [_kDefaultFloatingActionButtonLocation]. | |||
There was a problem hiding this comment.
This doc reference would lead no where since it is a private constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Getter for floatingActionButtonLocation in ScaffoldState.
Fixes #147804
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.