Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra EKS values file from flyte-binary #5212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove extra EKS values file from flyte-binary #5212

wants to merge 1 commit into from

Conversation

davidmirror-ops
Copy link
Contributor

Why are the changes needed?

What changes were proposed in this pull request?

This PR removes a values file that doesn't contain anything new compared to the eks-starter.yaml file provided.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@davidmirror-ops
Remove extra values file
4f88fb8 
Signed-off-by: davidmirror-ops <david.espejo@union.ai>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Apr 10, 2024
pingsutw
pingsutw approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove eks-starter.yaml instead? eks-production.yaml sounds like production ready 😆

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 10, 2024
@davidmirror-ops
Copy link
Contributor Author

@pingsutw I think the idea here is aligning with the other charts where a single starter values file is provided. What's considered "production-grade" varies a lot per organizations. Even this "starter" file is opinionated (eg. is ingress considered "starter"?) So I guess having the most common overrides on a values file is what we could look for :)

@pingsutw
Copy link
Member

Ah, I see; that makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingsutw pingsutw pingsutw approved these changes

Assignees
No one assigned
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidmirror-ops @pingsutw