helm: Add support for passing env variables to flyteadmin using envFrom #5216
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
dosubot
bot
added
size:S
Signed-off-by: Chris Soyars <chris@union.ai>
ctso
force-pushed
the
ctso/flyte-core-chart-envfrom
branch
from
1cd6313
to
9ff19da
Compare
pmahindrakar-oss
previously approved these changes
Apr 11, 2024
Signed-off-by: Chris Soyars <chris@union.ai>
ctso
force-pushed
the
ctso/flyte-core-chart-envfrom
branch
from
fae3f59
to
acf00e7
Compare
pmahindrakar-oss
approved these changes
Apr 11, 2024
|
Should we match ? |
pingsutw
approved these changes
Apr 11, 2024
|
@ctso I think it would feel nicer if at least the value var names matched between single binary and flyte-core. yah? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to #3970
Why are the changes needed?
Users may want to pass environment variables from Secrets or ConfigMaps instead of relying on the Helm chart's
flyteadmin.secretsHelm value. This is convenient when using a secrets manager such as External Secrets, for example.What changes were proposed in this pull request?
Add a new Helm value,
flyteadmin.envFromwhich you can pass through directly to the underlying Deployment.How was this patch tested?
Tested locally using
helm template, it works.Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link