Add appProtocol to agent service to allow agent to work with istio #5240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: noahjax <noah.jackson@dominodatalab.com>
dosubot
bot
added
size:XS
|
I think you just need to run the local tools to update the generated files and such:
|
Signed-off-by: noahjax <noah.jackson@dominodatalab.com>
dosubot
bot
added
size:S
ddl-ebrown
reviewed
Apr 17, 2024
| @@ -40,6 +40,7 @@ spec: | |||
| - name: agent-grpc | |||
| port: 8000 | |||
| protocol: TCP | |||
| appProtocol: TCP | |||
Signed-off-by: noahjax <noah.jackson@dominodatalab.com>
dosubot
bot
added
size:M
Signed-off-by: noahjax <noah.jackson@dominodatalab.com>
noahjax
force-pushed
the
noahjax.add-appProtocol-to-agent
branch
from
14660e5
to
bbcefcd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5240 +/- ##
==========================================
- Coverage 58.60% 58.15% -0.46%
==========================================
Files 568 204 -364
Lines 51121 15429 -35692
==========================================
- Hits 29958 8972 -20986
+ Misses 18748 5627 -13121
+ Partials 2415 830 -1585
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
May 6, 2024
|
@noahjax could you run |
|
I'll take this one over too and try to update tomorrow. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
If you try to use an agent on a cluster with istio, flytepropeller is unable to connect to the agent. You will either need to remove the agent from flytepropeller's configmap or flytepropeller will fail on startup.
Connecting to flyteconsole is also broken in istio because missing appProtocol prevents some http ports from working correctly.
What changes were proposed in this pull request?
Specify an
appProtocolthat istio can use to determine how to proxy requests (see here for more details on how this works).Update: I also modified the flyteadmin and flyteconsole services so that they will work with istio as well. More extensive changes are necessary to get everything working, but I will split those into a separate PR as they are likely more controversial
How was this patch tested?
Tested on my flyte deployment with istio enabled for the whole cluster.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link