Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move tutorials docs to flyte #5290

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Apr 25, 2024

Why are the changes needed?

Move markdown versions of tutorials docs to flyte and use rli directive to include code from tutorials Python files in flytesnacks.

What changes were proposed in this pull request?

TK

TODO: update docs contribution guide.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

TK - there will be a related flytesnacks PR.

Docs link

TK

Signed-off-by: nikki everett <nikki@union.ai>
@neverett neverett self-assigned this Apr 25, 2024
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
…re causing test failures right now

Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.94%. Comparing base (8eb7b0d) to head (2f973a8).
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5290       +/-   ##
===========================================
- Coverage   76.78%   61.94%   -14.84%     
===========================================
  Files          18      151      +133     
  Lines        1516    10134     +8618     
===========================================
+ Hits         1164     6278     +5114     
- Misses        288     3262     +2974     
- Partials       64      594      +530     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: nikki everett <nikki@union.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant