Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking pixel to Flyte README and docs #5338

Closed
wants to merge 4 commits into from

Conversation

neverett
Copy link
Contributor

@neverett neverett commented May 8, 2024

Why are the changes needed?

Check all the applicable boxes

  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

TK

Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
@neverett neverett self-assigned this May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.09%. Comparing base (43c0f1a) to head (4fdb830).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5338      +/-   ##
==========================================
- Coverage   61.10%   61.09%   -0.01%     
==========================================
  Files         794      794              
  Lines       51213    51213              
==========================================
- Hits        31292    31289       -3     
- Misses      17039    17043       +4     
+ Partials     2882     2881       -1     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.86% <ø> (-0.05%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.30% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neverett
Copy link
Contributor Author

Superseded by #5341

@neverett neverett closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants