Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Refactor distributed job using common ReplicaSpec #5355

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MortalHappiness
Copy link
Contributor

@MortalHappiness MortalHappiness commented May 11, 2024

Tracking issue

Closes #4408

Why are the changes needed?

See the description of the issue.

What changes were proposed in this pull request?

  1. Create CommonReplicaSpec in common.proto
  2. For all original protobuf messages have the pattern XXXReplicaSpec, embed CommonReplicaSpec and delete all the fields that are declared in CommonReplicaSpec
  3. Update those golang files that are affected by the probobuf changes.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flytekit#2424

Docs link

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 61.08%. Comparing base (16d2b14) to head (81bceca).

Current head 81bceca differs from pull request most recent head 946ca70

Please upload reports for the commit 946ca70 to get more accurate results.

Files Patch % Lines
.../plugins/k8s/kfoperators/common/common_operator.go 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5355      +/-   ##
==========================================
+ Coverage   61.07%   61.08%   +0.01%     
==========================================
  Files         793      793              
  Lines       51210    51174      -36     
==========================================
- Hits        31274    31262      -12     
+ Misses      17060    17040      -20     
+ Partials     2876     2872       -4     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.31% <ø> (+0.33%) ⬆️
unittests-flyteidl 79.30% <ø> (+0.25%) ⬆️
unittests-flyteplugins 61.88% <16.66%> (-0.07%) ⬇️
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MortalHappiness MortalHappiness marked this pull request as ready for review May 16, 2024 16:08
@MortalHappiness MortalHappiness marked this pull request as draft May 17, 2024 04:43
@MortalHappiness MortalHappiness force-pushed the feature/#4408-refactor-replicaspec branch 2 times, most recently from 7051883 to 81bceca Compare May 18, 2024 11:07
@MortalHappiness MortalHappiness marked this pull request as ready for review May 18, 2024 11:07
Resolves: flyteorg#4408
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Resolves: flyteorg#4408
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
…uf changes

Resolves: flyteorg#4408
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the feature/#4408-refactor-replicaspec branch from 81bceca to 946ca70 Compare May 21, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core feature] Refactor distributed job using common ReplicaSpec
1 participant