Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation files for Spanish language #20368

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alvarohurtado84
Copy link

Hi there!

I know this PR is pretty big and the opposite is encouraged. However, they are all translation files to Spanish. There might be something else to add to make it functional, I could not find more information about new languages in the documentation.

As this is my first PR, I tried signing this (https://cla-assistant.io/forem/forem) but it is not available. I will do it happily.

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

I added translations to Spanish for all the locales I found.

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Keyboard operability supported?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

For more info, check out the
Forem Accessibility Docs.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

I am not sure how to add tests on this, if it is necessary at all.

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@alvarohurtado84 alvarohurtado84 requested review from a team as code owners November 17, 2023 17:37
@alvarohurtado84 alvarohurtado84 requested review from maestromac and lightalloy and removed request for a team November 17, 2023 17:37
Copy link
Contributor

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

Copy link
Contributor

github-actions bot commented Nov 17, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@alvarohurtado84
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@lightalloy lightalloy requested review from benhalpern and removed request for lightalloy November 18, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant