Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feedback response email text #20544

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jessleenyc
Copy link
Contributor

@jessleenyc jessleenyc commented Jan 19, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Keyboard operability supported?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

For more info, check out the
Forem Accessibility Docs.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

Copy link
Contributor

github-actions bot commented Jan 19, 2024

Uffizzi Ephemeral Environment deployment-44733

☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20544

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@jessleenyc jessleenyc marked this pull request as ready for review February 29, 2024 17:37
@jessleenyc jessleenyc requested a review from a team as a code owner February 29, 2024 17:37
@jessleenyc jessleenyc requested review from lightalloy and maestromac and removed request for a team February 29, 2024 17:37
We appreciate your help as we work to foster a positive and inclusive environment for all.
</p>

<p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should have <% if Page.find_by(slug: "community-moderation") %> and use app_url

Basically same as the logic you see here:

app/views/mailers/notify_mailer/trusted_role_email.text.erb

Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes need to be modified slightly so they're not hardcoded quite this much. I left a reference to an example in my comments.

Should be good to go after that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants