Add simple query to member manager index when no filters selected #20770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
369
to
370
|
|
||
| def set_user_details |
There was a problem hiding this comment.
📝 [rubocop] <Layout/EmptyLines> reported by reviewdog 🐶
Extra blank line detected. (https://rubystyle.guide#two-or-more-empty-lines)
Suggested change
| def set_user_details | |
| def set_user_details |
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20770 ⚙️ Updating now by workflow run 8708928334. What is Uffizzi? Learn more! |
PhilipHow
changed the title
PhilipHow
requested review from
lightalloy and
maestromac
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This replaces the existing query for member manager with a simplified one when no filters are selected (i.e. when it is first accessed) in a hope it speeds up the initial page load.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.