fix: add lsp in dev container #20851
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dambar08
requested review from
lightalloy and
maestromac
and removed request for
a team
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20851 ⚙️ Updating now by workflow run 8606826286. What is Uffizzi? Learn more! |
maestromac
reviewed
Apr 8, 2024
| @@ -127,6 +127,7 @@ group :development do | |||
| gem "i18n-tasks", "~> 1.0.11" # Helpers to find and manage missing and unused translations | |||
| gem "listen", "~> 3.7", require: false # Helps 'listen' to file system modifications events (also used by other gems like guard) | |||
| gem "memory_profiler", "~> 1.0", require: false # Memory profiling routines for Ruby 2.3+ | |||
| gem "ruby-lsp", "~> 0.16.2", require: false | |||
There was a problem hiding this comment.
This should not be necessary. Upon devcontainer launch, vscode lsp extension will install ruby-lsp. You can see it working in the output tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
We do not use ruby version manager in dev container, which does not install ruby-lsp server automatically. Causing the ruby-lsp server from starting.
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
CriticalandSeriousissues?Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.