Track pageviews for custom pages #20879
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20879 ⚙️ Updating now by workflow run 9019123388. What is Uffizzi? Learn more! |
PhilipHow
changed the title
PhilipHow
requested review from
maestromac and
lightalloy
and removed request for
a team
| class AddPageToPageViews < ActiveRecord::Migration[7.0] | ||
| disable_ddl_transaction! | ||
|
|
||
| def change | ||
| add_reference :page_views, :page, null: true, index: {algorithm: :concurrently} | ||
| end | ||
| end |
There was a problem hiding this comment.
I'm a little bit conflicted on this. The ideal way to go about this is to make a polymorphic association/model that will then allow any model to be in relation with PageView but I can see this to be a quick way to get this feature implemented first.
There was a problem hiding this comment.
Yup, I discussed this with @benhalpern. Data migration was the main concern with a polymorphic approach.
Are there any ways of sidestepping this issue if we went down a polymorphic approach?
There was a problem hiding this comment.
Yeah I think this has to be the first take on this as the path forward
What type of PR is this? (check all applicable)
Description
Adds page_id to
PageViewsand tracks page views when a user visits a page.Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?