Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show acheived amount and variance for parent item groups #41495

Merged

Conversation

nabinhait
Copy link
Member

Issue:
If a target is set against any parent item group, the system does not show the achieved amount for it in the target variance report.

Reports:

  1. Territory Target Variance Based On Item Group
  2. Sales Person Target Variance Based On Item Group
  3. Sales Partner Target Variance Based On Item Group

After fix:

Screenshot 2024-05-16 at 2 31 44 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 16, 2024
@nabinhait nabinhait merged commit e22b0fd into frappe:develop May 20, 2024
14 checks passed
nabinhait added a commit that referenced this pull request May 21, 2024
#41495) (#41551)

fix: Show achieved amount and variance for parent item groups

(cherry picked from commit 8ac11ae)

Co-authored-by: Nabin Hait <nabinhait@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request May 22, 2024
# [15.25.0](v15.24.1...v15.25.0) (2024-05-22)

### Bug Fixes

* added validation message for low gross purchase amount (backport [#41502](#41502)) ([#41553](#41553)) ([89ba7a2](89ba7a2))
* Auto reconcile only after selecting bank account (backport [#41489](#41489)) ([#41554](#41554)) ([33eb251](33eb251))
* bold total in exponential smoothing forecasting (backport [#41393](#41393)) ([#41404](#41404)) ([8101b51](8101b51))
* BOM creator validation for parent row no (backport [#41413](#41413)) ([#41558](#41558)) ([953de99](953de99))
* convert invoice_portion value from str to float (backport [#41485](#41485)) ([#41555](#41555)) ([0a36139](0a36139))
* correct report name in inner button (backport [#41568](#41568)) ([#41572](#41572)) ([4ccc426](4ccc426))
* create custom field for accounting dimensions only if the field not exists already ([#41557](#41557)) ([68fa55c](68fa55c))
* Deadlock on submitting Sales Invoice (backport [#41417](#41417)) ([#41562](#41562)) ([49db19d](49db19d))
* Demo data clearing ([46ec61f](46ec61f))
* Filters in trend reports ([52d5d7a](52d5d7a))
* job card time logs overlap issue (backport [#41567](#41567)) ([#41571](#41571)) ([6554f19](6554f19))
* minor Dr and Cr between Purchase Receipt and Purchase Invoice ([3872cdc](3872cdc))
* not able to delete line items in the subcontracting receipt (backport [#41569](#41569)) ([#41570](#41570)) ([26c3235](26c3235))
* not able to submit landed cost voucher (backport [#41481](#41481)) ([#41486](#41486)) ([a070ad7](a070ad7))
* possible sql error on General Ledger ([e0a0cb7](e0a0cb7))
* print format bold for field "total" ([e36880d](e36880d))
* priority not working for multiple pricing rules (backport [#41516](#41516)) ([#41525](#41525)) ([5fd68f9](5fd68f9))
* Show acheived amount and variance for parent item groups (backport [#41495](#41495)) ([#41551](#41551)) ([5e0bff3](5e0bff3))
* stock levels for batch (backport [#41494](#41494)) ([#41501](#41501)) ([938888c](938888c))
* timeout error while submitting purchase invoice (backport [#41520](#41520)) ([#41522](#41522)) ([fcd9f89](fcd9f89))
* typerror on hide_fields ([8ae9da5](8ae9da5))
* Unable to add items in POS Invoice ([a90186f](a90186f))
* validate reorder group warehouse (backport [#41478](#41478)) ([#41480](#41480)) ([a1ce514](a1ce514))
* valuation rate for legacy serial nos (backport [#41543](#41543)) ([#41545](#41545)) ([f121b33](f121b33))

### Features

* Config to enable immutable ledger ([32c935b](32c935b))
* enter serial range in Serial/Batch Selector (backport [#41530](#41530)) ([#41534](#41534)) ([7225347](7225347))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant