Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
NumConditional
that usesprod
ex
for some reason, we will need to have a new entry inqt
forcondWithDefaultOne
or something. Otherwise, this default 0 will cause those conditionals to always be 0. That would require there to be a use case where 2 values are writing to the same conditional for some reason, which doesn't really make sense.ListConditionals
to havedef
(default 0) when set to 0 (such as above)Issue or discord link
Testing/validation
Tested using WIP
CalcContext
that contains hard-coded conditional data. Default value was working as expected, and a specified conditional would override this default.Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.