Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support naive date #1950

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

Conversation

TrackerSB
Copy link
Contributor

@TrackerSB TrackerSB commented May 18, 2024

Changes

Implement the feature requested in #1833.

(EDIT by @fzyzcjy to let github link automatically) Close #1833

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@TrackerSB
Copy link
Contributor Author

Replaces #1834

@TrackerSB TrackerSB force-pushed the support-naive-date branch 4 times, most recently from f2ab1a1 to eb1f64f Compare May 25, 2024 09:02
@TrackerSB
Copy link
Contributor Author

Does "./frb_internal precommit --mode slow" enforce having installed all required targets like wasm32, windows, macos, android, etc.?

@TrackerSB
Copy link
Contributor Author

I'm asking asking since it deletes all folders related to windows, ios, macos and android in flutter_via_create and flutter_via_integrate without obviously failing.
output.log

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 63.33%. Comparing base (d46844b) to head (747acea).
Report is 9 commits behind head on master.

Current head 747acea differs from pull request most recent head 75a3834

Please upload reports for the commit 75a3834 to get more accurate results.

Files Patch % Lines
...library/codegen/generator/codec/sse/ty/delegate.rs 0.00% 13 Missing ⚠️
...rt/spec_generator/codec/cst/encoder/ty/delegate.rs 0.00% 7 Missing ⚠️
...st/spec_generator/codec/cst/decoder/ty/delegate.rs 0.00% 6 Missing ⚠️
frb_codegen/src/library/codegen/ir/ty/delegate.rs 0.00% 2 Missing ⚠️
.../codegen/generator/api_dart/spec_generator/info.rs 0.00% 1 Missing ⚠️
...rt/spec_generator/codec/dco/decoder/ty/delegate.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1950       +/-   ##
===========================================
- Coverage   99.24%   63.33%   -35.91%     
===========================================
  Files         387      378        -9     
  Lines       16491    15459     -1032     
===========================================
- Hits        16366     9791     -6575     
- Misses        125     5668     +5543     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy
Copy link
Owner

fzyzcjy commented May 25, 2024

Given the CI errors, I guess you mainly need ./frb_internal generate-internal-frb-example-pure-dart ; ./frb_internal precommit-generate, which is faster (and runs a subset of full precommit).

@TrackerSB
Copy link
Contributor Author

Almost there, but I have to have a look into the asynchronous variant of the tests.

@fzyzcjy
Copy link
Owner

fzyzcjy commented May 27, 2024

Looking forward to it!

@TrackerSB
Copy link
Contributor Author

How can it be that only Ubuntu and windows are falling or do I misinterpret the CI output?

@fzyzcjy
Copy link
Owner

fzyzcjy commented May 28, 2024

How can it be that only Ubuntu and windows are falling or do I misinterpret the CI output?

Maybe MacOS is still in queue?
Usually I only look at Ubuntu if multiple platform fails, since that one often runs fastest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support converting chrono::NativeDate to Dart
2 participants