-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support naive date #1950
base: master
Are you sure you want to change the base?
Support naive date #1950
Conversation
Replaces #1834 |
11d7402
to
ed15341
Compare
f2ab1a1
to
eb1f64f
Compare
eb1f64f
to
6992dc7
Compare
Does "./frb_internal precommit --mode slow" enforce having installed all required targets like wasm32, windows, macos, android, etc.? |
I'm asking asking since it deletes all folders related to windows, ios, macos and android in flutter_via_create and flutter_via_integrate without obviously failing. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1950 +/- ##
===========================================
- Coverage 99.24% 63.33% -35.91%
===========================================
Files 387 378 -9
Lines 16491 15459 -1032
===========================================
- Hits 16366 9791 -6575
- Misses 125 5668 +5543 ☔ View full report in Codecov by Sentry. |
Given the CI errors, I guess you mainly need |
…_internal precommit-generate"
…_internal precommit-generate"
1192a6a
to
9fd97e4
Compare
Almost there, but I have to have a look into the asynchronous variant of the tests. |
Looking forward to it! |
…_internal precommit-generate"
4515cb0
to
75a3834
Compare
How can it be that only Ubuntu and windows are falling or do I misinterpret the CI output? |
Maybe MacOS is still in queue? |
Changes
Implement the feature requested in #1833.
(EDIT by @fzyzcjy to let github link automatically) Close #1833
Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.Remark for PR creator
./frb_internal --help
shows utilities for development.