Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Find and Replace dialogs text entry background management #3828

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ntrel
Copy link
Member

@ntrel ntrel commented Apr 10, 2024

Always reset backgrounds first on any dialog response, then set again if necessary.

  • When showing a dialog the background was only reset when using the document selected text, but the document contents could have changed e.g. to contain the previously unmatched search text, yet the background remained set.
  • The Find All responses didn't clear the background even when successful. This fixes those situations.

Set search entry background when there's a regex or escape error.
Set replace text entry background when there's an escape error.

Move fail branch to first use.
Focus replace entry if escaping failed.
The background can be set again if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant