-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ctags to p6.1.20240519.0 #3877
base: master
Are you sure you want to change the base?
Conversation
Just thinking, in #3859 I mapped matlab variables to So shouldn't we rather map it to |
Python does this too, every assignment is a new declaration and shows in the sidebar, on the other hand Julia (where assignment is also declaration) has chosen not to show any assignments in the sidebar, YMMV. |
Yes, but this happens only for the global variables, not variables inside functions. Since the matlab parser is just a dumb regex parser, it doesn't know whether it's inside a function so it shows all assignments and the result is a little too noisy. |
Yeah, if they are not scoped then its not very useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanna laugh? universal-ctags/ctags#4008 😄
Hum yeah if it's gonna tag every variable assignment in the file regardless of scope, it's probably better to disable indeed, otherwise the more useful tags are likely gonna be hard to find. Maybe |
The parser makes tags for each assignment which is too noisy.
I just mapped it to |
No problem. I've just included the updated jscript parser (without updating the rest). We can update the parsers individually if there are some fixes that should be present in the release. |
This PR contains some ctags updates which were made upstream as discussed in #3859.
Apart from that I noticed that the
update-ctags.py
script didn't copy the updated libreadtags library so I modified it to do so and as a result this PR also contains updated readtags.c/h which was missed in the previous PR.