conversion.py: Draft basic cleanup - UNTESTED #1897
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested these changes. Without unit tests, I would not trust these changes.
The goal was to capture some initial cleanups that can be done on this file.
Changes:
use_math()
with open()
scopesx = x + foo
→x += foo
if files is not None:
There is a lot more than can be done (like making most of this code totally isolated from Jupyter), but this is a start.
An easy starter unit test: