Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative Weight Support Added #1733

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

astraey
Copy link

@astraey astraey commented Jun 13, 2017

Modified the ForceAtlas and ForceAtlas2 layouts so it supports negative weights.

The main idea is that if a negative weight is detected, we redefine the minimum edge value to 0, and apply the corresponding operations to maintain the graph’s data integrity.

Bug Reproduction:

wqcfsq

Youtube Link
After Fix:

55fqo5

Youtube Link

@eduramiba eduramiba requested a review from jacomyma July 1, 2017 12:15
@eduramiba
Copy link
Member

Thanks for the request, we will need to review it.

@vlado-s
Copy link

vlado-s commented Oct 11, 2017

Hi,
could you please clarify what you mean by "if a negative weight is detected, we redefine the minimum edge value to 0"? Does it rescale all edge weight such that you add a constant of the absolute value for the most negative edge weight => that one becomes 0 and all others become more positive?
Thanks'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants