Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 fix: Single store page header style broken on multiple themes #2030

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

devAsadNur
Copy link
Member

@devAsadNur devAsadNur commented Oct 3, 2023

All Submissions:

  • My code follows the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Changelog entry

fix: Single store page header style broken on multiple themes

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you will understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@devAsadNur devAsadNur added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval labels Oct 3, 2023
@devAsadNur devAsadNur self-assigned this Oct 3, 2023
@nurul-umbhiya nurul-umbhiya added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Oct 3, 2023
@shashwatahalder01 shashwatahalder01 added QA In Progress and removed Needs: Testing This requires further testing labels Oct 4, 2023
@shashwatahalder01

This comment was marked as resolved.

@devAsadNur devAsadNur added Needs: Testing This requires further testing and removed Type: Bug labels Dec 14, 2023
@shashwatahalder01 shashwatahalder01 added QA In Progress and removed Needs: Testing This requires further testing labels Dec 14, 2023
@shashwatahalder01
Copy link
Contributor

Scenario:
store open-close is not fully visible.

Steps to reproduce:

  1. set open store close for a vendor
  2. go to the single store list page for that vendor

Screenshot:
Screenshot at Dec 15 16-29-18

@shashwatahalder01
Copy link
Contributor

shashwatahalder01 commented Dec 15, 2023

Scenario:
Design is broken for placeholder banner.

Steps to reproduce:

  1. set different layout and then go to single store page [store with default banner]

Screenshot:
PR:
Screenshot at Dec 15 14-38-12
Develop:
Screenshot at Dec 15 14-39-13

PR:
Screenshot at Dec 15 14-40-43

Develop:
Screenshot at Dec 15 14-41-02

PR:
Screenshot at Dec 15 14-41-51

Develop:
Screenshot at Dec 15 14-42-20

PR:
Screenshot at Dec 15 14-43-25

Develop:
Screenshot at Dec 15 14-43-39

@Sophie-2e
Copy link

Sophie-2e commented Apr 29, 2024

FYI This might also be related to this: #2259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Progress The issues is being worked on Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants