Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance: Update dokan admin dashboard logo & add logo update notice. #2258

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

MdAsifHossainNadim
Copy link
Contributor

Enhance: Update dokan admin logo & add logo update notice.

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

  • Full PR Link

Closes

How to test the changes in this Pull Request:

  • Go to dokan admin dashboard & see menu logo, admin settings logo, admin logo notice etc.

Changelog entry

Fix: Update dokan admin dashboard logo & add logo update notice.

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

image

After Changes

Screenshot 2024-04-26 at 4 25 58 PM

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@MdAsifHossainNadim MdAsifHossainNadim added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval labels Apr 26, 2024
@MdAsifHossainNadim MdAsifHossainNadim self-assigned this Apr 26, 2024
@MdAsifHossainNadim
Copy link
Contributor Author

@shohag121 Vhaiya, kindly review this PR at your convenience.

@shohag121 shohag121 added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Apr 29, 2024
@shashwatahalder01 shashwatahalder01 added QA In Progress and removed Needs: Testing This requires further testing labels Apr 29, 2024
@shashwatahalder01 shashwatahalder01 added QA approved This PR is approved by the QA team and removed QA In Progress QA approved This PR is approved by the QA team labels Apr 29, 2024
@shashwatahalder01
Copy link
Contributor

Scenario:
The icon needs to update on several places on dokan

Screenshot at Apr 29 17-04-31
Screenshot at Apr 29 17-05-50
Screenshot at Apr 29 17-08-28
Screenshot at Apr 29 17-08-49

includes/Admin/Notices/Manager.php Outdated Show resolved Hide resolved
includes/Admin/Notices/Manager.php Outdated Show resolved Hide resolved
includes/Admin/Notices/Manager.php Outdated Show resolved Hide resolved
includes/Admin/Notices/Manager.php Outdated Show resolved Hide resolved
includes/Admin/Notices/Manager.php Outdated Show resolved Hide resolved
includes/Admin/Notices/Manager.php Outdated Show resolved Hide resolved
@MdAsifHossainNadim
Copy link
Contributor Author

@mrabbani Vhai, need to relevant ui's for new issues.
@shashwatahalder01 Vhai, If anything is required or if you have any suggestions for us, then feel free to inform us.

@shashwatahalder01
Copy link
Contributor

@MdAsifHossainNadim, @mrabbani,
It would be better if we could introduce a new color pallet that is aligned with the latest dokan logo

image

@tuhin480
Copy link

tuhin480 commented May 7, 2024

Here is the Design Link. Please have a look.

@MdAsifHossainNadim
Copy link
Contributor Author

MdAsifHossainNadim commented May 16, 2024

@tuhin480 Vhai, we need to make consistent between existing banner & updated logo. Here is the preview after updating logo.

Screenshot 2024-05-08 at 9 27 54 AM
Screenshot 2024-05-08 at 9 27 07 AM

I think It will be better if we added some shadow or spaces on left/bottom side in this banner image. (as like as previous)

image

Screenshot 2024-05-08 at 9 55 21 AM

We need to update wp org's banner & icon logo's as per latest update.

image (35)

CC: @mrabbani @ashrafux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants