add: urlencode selector - space as plus or 20

[veshus]

What type of PR is this?

• Refactor
• Feature
• Bug Fix
• New Query Runner (Data Source)
• New Alert Destination
• Other

Description

Add ability to change quoter for url encode query parameters from default "space as plus" to "space as %20".
Feature is controlled by env REDASH_URLENCODE_SPACE_AS_PLUS = true|false

How is this tested?

• Unit tests (pytest, jest)
• E2E Tests (Cypress)
• Manually
• N/A

I have an API that treats space as %20, so default behaviour doesn't work. After REDASH_URLENCODE_SPACE_AS_PLUS set to "false", all parameters passes ok.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

[codecov]

Codecov Report

Merging #6621 (e60d3e2) into master (f7b47c0) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 50.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6621      +/-   ##
==========================================
- Coverage   62.39%   62.38%   -0.01%     
==========================================
  Files         161      161              
  Lines       13179    13184       +5     
  Branches     1796     1797       +1     
==========================================
+ Hits         8223     8225       +2     
- Misses       4672     4675       +3     
  Partials      284      284              

Files	Coverage Δ
redash/settings/__init__.py	98.66% <100.00%> (+<0.01%)	⬆️
redash/utils/requests_session.py	46.66% <40.00%> (-7.88%)	⬇️

[masayuki038]

Hi @veshus, thanks for the PR.

It seems that the part you added is not covered by unit tests. Could you please provide some testing to ensure that this change does not affect existing behavior? It is very helpful for us. thank you.

[masayuki038]

@veshus I found #6610.
Could you reply to it before adding some tests? I also would like to know the background of this update.

[guidopetri]

I'd also like some clarity on #6610 before merging