Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make json ds support nested path query #6948

Closed
wants to merge 2 commits into from

Conversation

gaecoli
Copy link
Member

@gaecoli gaecoli commented May 6, 2024

What type of PR is this?

  • Refactor
  • [x ] Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

How is this tested?

  • [ x] Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@gaecoli
Copy link
Member Author

gaecoli commented May 6, 2024

There is no rush to merge this branch. We should listen to users’ suggestions and provide guidance to satisfy users.

#6938

@SmallStrayFox
Copy link

compiled pr as docker image and tested and can now traverse nested json, e.g. as per original comment #6938 with example json, can now for instance set path: data.0.awarded.0 to access the awarded array, however it currently only returns 1 record, e.g. if calling api would usually return 100 awarded array objects then i'd expect setting the path as above to return them all when i run the query in redash.

@gaecoli gaecoli closed this May 17, 2024
@justinclift justinclift deleted the json-support-nested-path branch May 17, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants