Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Remove unused expression in 'highlightsDataSection.spec.tsx' #71149

Merged
merged 1 commit into from
May 21, 2024

Conversation

floels
Copy link
Contributor

@floels floels commented May 18, 2024

Goal

The goal of this PR is to remove an unused expression at the top of file static/app/components/ events/highlights/highlightsDataSection.spec.tsx:

import {EventFixture} from 'sentry-fixture/event';
import {GroupFixture} from 'sentry-fixture/group';
import {OrganizationFixture} from 'sentry-fixture/organization';
import {ProjectFixture} from 'sentry-fixture/project';
import {render, screen, within} from 'sentry-test/reactTestingLibrary';
import * as modal from 'sentry/actionCreators/modal';
import HighlightsDataSection from 'sentry/components/events/highlights/highlightsDataSection';
import * as analytics from 'sentry/utils/analytics';
HighlightsDataSection;
import {EMPTY_HIGHLIGHT_DEFAULT} from 'sentry/components/events/highlights/util';
import {
TEST_EVENT_CONTEXTS,
TEST_EVENT_TAGS,
} from 'sentry/components/events/highlights/util.spec';

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Remove an unused expression at the top of file 'static/app/components/
events/highlights/highlightsDataSection.spec.tsx'.
@floels floels requested a review from a team as a code owner May 18, 2024 17:00
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 18, 2024
Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (3b17f23) to head (86e1d47).
Report is 55 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #71149      +/-   ##
==========================================
- Coverage   79.70%   77.88%   -1.83%     
==========================================
  Files        6701     6528     -173     
  Lines      300378   290852    -9526     
  Branches    50340    50340              
==========================================
- Hits       239425   226520   -12905     
+ Misses      60521    58085    -2436     
- Partials      432     6247    +5815     

see 1732 files with indirect coverage changes

@leeandher leeandher added the Trigger: getsentry tests once code is reviewed: apply label to PR to trigger getsentry tests label May 21, 2024
@leeandher leeandher self-assigned this May 21, 2024
Copy link
Member

@leeandher leeandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@leeandher leeandher merged commit 2cf3c5e into getsentry:master May 21, 2024
44 of 45 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants