-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: merge
key for key groups
#1493
base: main
Are you sure you want to change the base?
Feature: merge
key for key groups
#1493
Conversation
closes getsops#1123 Signed-off-by: Jonas Badstübner <jonas.badstuebner@hetzner-cloud.de>
9fbc9ea
to
372d21b
Compare
Just so I have said it: This does not ensure that a key is included only once. Maybe this is a desirable feature when people start merging But that is not any different from the overall |
Should also mention: |
Would be nice to get an ETA of when this will be looked at and maybe an ETA for a new patch release that includes this feature? |
@felixfontein Sorry to bother you again, but what is the current state of sops, it seems to be very slow moving and the last patch release has been a long time ago. Why does a small MR like this take so much time to review and merge and when is the next patch release planned? 3.9.0 is on the road map for a very long time already, do you need help or is it something else? |
It seems that most maintainers currently have no time to review PRs. Since I don't want to merge PRs that I don't fully understand without a second review, this means that rarely any PRs get merged currently. I was hoping for a soonish 3.9.0 release for some time already, I have no idea when it will happen. |
If you need maintainers, I would be happy to support sops. Who would be in charge of deciding this and what would I have to do? |
I'm not sure how the process works, but joining the #sops-dev channel on the CNCF Slack (https://github.com/getsops/sops/blob/main/CONTRIBUTING.md#communication, the second link allows you to get an invite for the CNCF Slack, and the former then allows you to join that channel) is probably a good idea. |
This closes #1123
The test is not very great (as in: "It doesn't check very much"), but since it was not too hard to implement, I think this is okay.
If you have any comments, please let me know.