Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting multiple command encoders per frame causes hang on Vulkan #5693

Closed
PWhiddy opened this issue May 12, 2024 · 7 comments · Fixed by #5681
Closed

Submitting multiple command encoders per frame causes hang on Vulkan #5693

PWhiddy opened this issue May 12, 2024 · 7 comments · Fixed by #5681

Comments

@PWhiddy
Copy link
Contributor

PWhiddy commented May 12, 2024

Description
Frames hanging for 5-10 seconds (presumably until timeout).
I bisected the issue and found it was introduced in #4967.

Possibly related to #5662

Repro steps
It only happens for me when submitting multiple command encoders with render passes in a single frame.
I don't have a minimal reproduction yet, but I wanted to share in case anyone else has encountered the same issue.

Platform
Ubuntu 22.04, nvidia 4090 - 535.86.10

@Wumpf
Copy link
Member

Wumpf commented May 12, 2024

@PWhiddy can you try on

this specifically addresses Vulkan submission

@PWhiddy
Copy link
Contributor Author

PWhiddy commented May 12, 2024

@Wumpf
That did indeed fix it, thanks!

@ggadwa
Copy link

ggadwa commented May 13, 2024

I posted an earlier issue on this: #5663

That'll be a duplicate now and can be closed.

@teoxoy
Copy link
Member

teoxoy commented May 13, 2024

@ggadwa so, #5681 fixes the issue you reported in #5663?

@ggadwa
Copy link

ggadwa commented May 13, 2024

@ggadwa so, #5681 fixes the issue you reported in #5663?

Yes! Didn't do a lot of testing -- but before it would immediately freeze and with that branch it behaves as it always did.

@ggadwa
Copy link

ggadwa commented May 13, 2024

Delete if too OT, but my game on steam that uses wgpu if you want to include it in your uses wpgu list (released in a couple days, uses the previous wgpu version for obvious reasons): https://store.steampowered.com/app/2933470/Atomite/

@cwfitzgerald
Copy link
Member

Cool! We have a list over on https://github.com/gfx-rs/wgpu-rs.github.io if you want to add it it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants