Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vulkan to cmake build #730

Merged
merged 7 commits into from May 25, 2024
Merged

Add Vulkan to cmake build #730

merged 7 commits into from May 25, 2024

Conversation

abetlen
Copy link
Contributor

@abetlen abetlen commented Feb 12, 2024

  • Adds a GGML_VULKAN option to cmake to allow building those sources into ggml
  • Adds the ggml_vk_generate_shaders.py and ggml-vulkan-shaders.hpp from llama.cpp to src/

@ggerganov
Copy link
Owner

We should wait for ggerganov/llama.cpp#5356 to see if they come up with a way to re-organize the Vulkan shaders

@abetlen
Copy link
Contributor Author

abetlen commented Feb 12, 2024

Makes sense, no rush for me I was just experimenting with the new backends.

@foldl
Copy link
Contributor

foldl commented May 15, 2024

ggerganov/llama.cpp#5356 is closed for being inactive.

So, any updates?

@abetlen
Copy link
Contributor Author

abetlen commented May 17, 2024

@ggerganov maybe for now I can just remove the auto-generated .hpp file and update the sync scripts. That should at least allow users to build with Vulkan by first running the python script to generate the shaders. How does that sound?

@ggerganov
Copy link
Owner

@abetlen Ok, let's do that

@abetlen
Copy link
Contributor Author

abetlen commented May 24, 2024

@ggerganov okay, I've removed the auto-generated file and updated the sync scripts. I also updated the ggml_vk_generate_shaders.py file to match the current ggml-vulkan files.

@ggerganov ggerganov merged commit a10a8b8 into ggerganov:master May 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants