The path to metal files is not validated when whisper.cpp is used as a subproject #2110
Comments
ggerganov
added a commit
that referenced
this issue
May 13, 2024
bygreencn
added a commit
to bygreencn/whisper.cpp
that referenced
this issue
May 14, 2024
* ggerganov/master: (291 commits) whisper : fix model path encoding in windows (ggerganov#2086) server : return utf-8 (ggerganov#2138) node : add audio_ctx and audio buffer params (ggerganov#2123) cmake : fix HIP/ROCm build (ggerganov#2102) node : add additional params (ggerganov#2000) js : remove un-needed request header from fetchRemote (ggerganov#2119) cmake : fix metal embed sources path (ggerganov#2110) main : dont print timings with --no-prints (ggerganov#2108) main : add options for temperature control (ggerganov#2088) whisper : switch back to F32 mask (#0) whisper.android : update example, add field to print timestamp (ggerganov#2072) cmake : fix json INTERFACE library (ggerganov#2069) main : fix double quote escaping in csv output (ggerganov#2090) metal : tune soft_max number of threads (#0) whisper : remove old flash attn code (#0) ggml : try fix ppc64 (#0) ggml : remove oboslete alibi code (skipme) (#0) talk-llama : sync llama.cpp sync : ggml ggml : optimize for ppc64le using VSX intrinsics (ggml/784) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When whisper.cpp is used as a sub-project with
WHISPER_METAL_EMBED_LIBRARY=ON, the file paths of ggml-metal.metal and ggml-common.h are invalid because they use${CMAKE_SOURCE_DIR}instead of${CMAKE_CURRENT_SOURCE_DIR}.This would allow whisper.cpp to be used as a subproject with
WHISPER_METAL_EMBED_LIBRARY=ON. I can create a PR if needed.The text was updated successfully, but these errors were encountered: