-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fix metal #148
Feature/fix metal #148
Conversation
@tazz4843 reformatted code |
See review comments |
@tazz4843 Hey I have found a new possible way here. whisper.cpp has now supported maybe we should consider finalize #142 first then I can start implement a new build option here? |
#142 has been merged, took me super long, sorry about that. Embedding the library is a much better idea imo and we should favour that. |
I tried it using |
updated. please help check the new build config. also I v updated the metal log callback setup function. |
I don't have macOS to test on, will wait for a positive test from someone with macOS before merging |
I have self-tested it since I m using it for a private project. But its okay if one more tester passed it. |
I have tested @hlhr202's latest changes by adding
Would be great if we can merge this, and thanks @hlhr202 for your fix! |
This is a naive fix for metal inference and log trampoline