automatic dependancy management with conan #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added clang-tidy and clang-format files for formatting and linting facelifted cmake files a little
Jihadist
reviewed
Mar 17, 2022
| SET(AGG_MINOR_VERSION 1 ) | ||
| SET(AGG_BUILD_VERSION 1 ) | ||
| # support conan package manager | ||
| include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake) |
There was a problem hiding this comment.
Looks like bad practice. We cannot compile without conan, conan should be used transparently
Jihadist
reviewed
Mar 17, 2022
| ${antigrain_SOURCE_DIR}/include/ctrl/agg_bezier_ctrl.h | ||
| ) | ||
| target_include_directories(antigrain PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/../include) | ||
| target_link_libraries(antigrain PUBLIC CONAN_PKG::expat) |
There was a problem hiding this comment.
Here you link conan package expat insted of cmake target expat
Jihadist
reviewed
Mar 17, 2022
|
|
||
| ADD_LIBRARY( antigrain | ||
| # main lib | ||
| add_library( antigrain STATIC |
There was a problem hiding this comment.
antigrain can also be shared but not for windows
Zardshard
pushed a commit
to Zardshard/ghaerr-agg-2.6
that referenced
this pull request
Aug 7, 2023
unix fixes, add linux github action
GerHobbelt
pushed a commit
to GerHobbelt/agg
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I wanted to use antigrain as a conan package in another project to avoid dependancy issues. So what I did was:
On my linux machine it compiles well. I hope I didn't break to much.
Is there something useful to this?
Yours
Timo