Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timeline for issue/PR comments and actions #1762

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kounoike
Copy link
Contributor

This PR prettify issue/PR comments and actions.

  • change to timeline.
  • highlight your comments/actions by color.

Issue rendered as:

20171031-071249 - issue test - issue 5 - root test - google chrome

current user(user)'s comment show with light-blue header.

PR rendered as:
20171031-071326 - fix 1 - pull request 4 - root test - google chrome

Before submitting a pull-request to GitBucket I have first:

  • read the contribution guidelines
  • rebased my branch over master
  • verified that project is compiling
  • verified that tests are passing
  • squashed my commits as appropriate (keep several commits if it is relevant to understand the PR)
  • marked as closed using commit message all issue ID that this PR should correct

@takezoe
Copy link
Member

takezoe commented Nov 2, 2017

@kounoike Vertical lines under avator images were removed to reduce similarity to GitHub before. We shouldn't go back.

@kounoike
Copy link
Contributor Author

kounoike commented Nov 3, 2017

@takezoe Vertical line is only one element of design. I think it is trivial parts. GitHub uses vertical line and horizontal line for separating actions. My design uses only vertical line for meaning as timeline.

There are more similar elements such as:

  • Action icons with circle
  • Action associated colors
  • Icon meanings
  • labels/assignees/etc in right column

So if you want reducing similarity, is this design preferred?

20171103-221948 - issue1 - issue 1 - root test - google chrome

@McFoggy
Copy link
Member

McFoggy commented Nov 3, 2017

What about simplifying it with more alignment?

image

or with the close/reopen without any background

image

@RadWolfie
Copy link

I would say first option would be better, with the background.

Also I would suggest to keep the close icon.

@edwardofclt
Copy link

edwardofclt commented Mar 1, 2018

I agree @RadWolfie; liked original better.
Would say that BitBucket has a similar featureset. Just because one person does it does not mean someone else can't do it too...

@zexxar
Copy link

zexxar commented Jun 25, 2018

I also think that the original solution was better. Also this would a be a great addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

6 participants