New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use timeline for issue/PR comments and actions #1762
base: master
Are you sure you want to change the base?
Conversation
@kounoike Vertical lines under avator images were removed to reduce similarity to GitHub before. We shouldn't go back. |
@takezoe Vertical line is only one element of design. I think it is trivial parts. GitHub uses vertical line and horizontal line for separating actions. My design uses only vertical line for meaning as timeline. There are more similar elements such as:
So if you want reducing similarity, is this design preferred? |
I would say first option would be better, with the background. Also I would suggest to keep the close icon. |
I agree @RadWolfie; liked original better. |
I also think that the original solution was better. Also this would a be a great addition. |
This PR prettify issue/PR comments and actions.
Issue rendered as:
current user(user)'s comment show with light-blue header.
PR rendered as:
Before submitting a pull-request to GitBucket I have first: