Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limits tags just on commit, show tags on commits page. close #1968 #1973

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kounoike
Copy link
Contributor

This PR is answer for #1968. It limits tags on commit.

image

And this PR also provide tag list on commit history page.

image

Before submitting a pull-request to GitBucket I have first:

  • read the contribution guidelines
  • rebased my branch over master
  • verified that project is compiling
  • verified that tests are passing
  • squashed my commits as appropriate (keep several commits if it is relevant to understand the PR)
  • marked as closed using commit message all issue ID that this PR should correct

@takezoe
Copy link
Member

takezoe commented Apr 25, 2018

@kounoike I agree with showing tags on the commits list, but don't agree with limiting tags in the commit page quickly. I can merge first one immediately if you split this pull request into two pull requests.

@kounoike
Copy link
Contributor Author

@takezoe How about changes like this (edit by dev-mode) screenshot? (tags are already expanded by click)

image

I think these changes are important

  • add which tag on this commit or "tag xxx pointed to after n commits"
  • add description for answer to "what tags are listed?"
  • sort tags by tagged date or other criteria not alphabetical order

But it requires more discussion. So I will make new PR which contains only commits list page changes.

kounoike added a commit to kounoike/gitbucket that referenced this pull request Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants