Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add + in validate page name should return invalid charactor #2414

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mrgleam
Copy link

@mrgleam mrgleam commented Jan 9, 2020

all issue 2412 that this PR should correct

Before submitting a pull-request to GitBucket I have first:

  • read the contribution guidelines
  • rebased my branch over master
  • verified that project is compiling
  • verified that tests are passing
  • squashed my commits as appropriate (keep several commits if it is relevant to understand the PR)
  • marked as closed using commit message all issue ID that this PR should correct

all issue 2412 that this PR should correct
@SIkebe
Copy link
Member

SIkebe commented Jan 10, 2020

Hmm... or is it really need to be decoded here?

val pageName = StringUtil.urlDecode(params("page"))

@SIkebe
Copy link
Member

SIkebe commented Jan 10, 2020

#2412

@mrgleam
Copy link
Author

mrgleam commented Jan 10, 2020

Hmm... or is it really need to be decoded here?

val pageName = StringUtil.urlDecode(params("page"))

Line 76 Fixed Issue #35

I'm not sure.

@SIkebe
Copy link
Member

SIkebe commented Jan 10, 2020

Line 76 Fixed Issue #35

Yeah, however current codebase seems to work without decoding...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants