Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown toolbar #2528

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

onukura
Copy link
Member

@onukura onukura commented Aug 27, 2020

Before submitting a pull-request to GitBucket I have first:

  • read the contribution guidelines
  • rebased my branch over master
  • verified that project is compiling
  • verified that tests are passing
  • squashed my commits as appropriate (keep several commits if it is relevant to understand the PR)
  • marked as closed using commit message all issue ID that this PR should correct

About this PR

revised #2517 . This PR add markdown toolbar for editor to resolve #1793 and might help #1411.

@takezoe This PR also fixed wired behaviors you mentioned in the last comment except the one below.

Undo doesn't work after modifying text using toolbar

pr_screenshot_list

@onukura onukura added this to the 4.35.0 milestone Aug 27, 2020
@onukura onukura requested review from takezoe and SIkebe August 27, 2020 14:09
Copy link
Member

@takezoe takezoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works very well!!

One thing I noticed is that it would be better the insert code button can quote multi-lines code fragment properly. In GitHub, it quotes with a single quote when a single line code fragment is selected and quotes with triple quotes when multi-lines are selected. But even without it, this is much beneficial to edit Markdown content.

@onukura Do you afford to update this to support quoting multi-lines code fragment? Otherwise, I will merge this as it is.

@onukura
Copy link
Member Author

onukura commented Nov 4, 2020

Do you afford to update this to support quoting multi-lines code fragment? Otherwise, I will merge this as it is.

@takezoe I didn't notice this... I think it's better to include in this PR.
And another missing feature is "undo". I am concerned that missing "undo" will cause poor usability...

Anyway "multi-line code fragment" and "undo" will take time to implement. I will try to find time to handle them.
However if next release 4.35.0 is around the corner, this feature might be in 4.36.0.

@takezoe
Copy link
Member

takezoe commented Nov 6, 2020

However if next release 4.35.0 is around the corner, this feature might be in 4.36.0.

Got you. I will exclude this from 4.35.0 if this pull request is not ready to merge by the next release.

@takezoe takezoe modified the milestones: 4.35.0, 4.36.0 Dec 13, 2020
@takezoe
Copy link
Member

takezoe commented Dec 13, 2020

Moved to 4.36.0.

@takezoe takezoe modified the milestones: 4.36.0, 4.37.0 Jul 17, 2021
@takezoe takezoe removed this from the 4.37.0 milestone Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Add toolbar and help to Markdown editor
3 participants