New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markdown toolbar #2528
base: master
Are you sure you want to change the base?
Add markdown toolbar #2528
Conversation
3611da3
to
d6830ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works very well!!
One thing I noticed is that it would be better the insert code button can quote multi-lines code fragment properly. In GitHub, it quotes with a single quote when a single line code fragment is selected and quotes with triple quotes when multi-lines are selected. But even without it, this is much beneficial to edit Markdown content.
@onukura Do you afford to update this to support quoting multi-lines code fragment? Otherwise, I will merge this as it is.
@takezoe I didn't notice this... I think it's better to include in this PR. Anyway "multi-line code fragment" and "undo" will take time to implement. I will try to find time to handle them. |
d6830ac
to
a451fda
Compare
Got you. I will exclude this from 4.35.0 if this pull request is not ready to merge by the next release. |
Moved to 4.36.0. |
Before submitting a pull-request to GitBucket I have first:
About this PR
revised #2517 . This PR add markdown toolbar for editor to resolve #1793 and might help #1411.
@takezoe This PR also fixed wired behaviors you mentioned in the last comment except the one below.