Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[registry-facade] switch to use hostPort #19739

Merged
merged 2 commits into from
May 14, 2024
Merged

[registry-facade] switch to use hostPort #19739

merged 2 commits into from
May 14, 2024

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented May 13, 2024

Description

[registry-facade] switch to use hostPort

Related Issue(s)

Fixes ENT-30

How to test

Tested mutil workspace node
SCR-20240513-opno

Tested start from zero node

SCR-20240513-orty

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@iQQBot
Copy link
Contributor Author

iQQBot commented May 13, 2024

Also tested on BYON cell

image image

@iQQBot
Copy link
Contributor Author

iQQBot commented May 14, 2024

start an ephemeral workspace from main branch, and manually apply this PR changes to the cluster, then use loadgen to start some workspace for test

workspace can start
image

The hostPort iptables rule
image

image

@kylos101
Copy link
Collaborator

Building a preview now

@kylos101
Copy link
Collaborator

Copy link
Collaborator

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@iQQBot
Copy link
Contributor Author

iQQBot commented May 14, 2024

/unhold

@roboquat roboquat merged commit c6f0571 into main May 14, 2024
49 checks passed
@roboquat roboquat deleted the pd/hostnetwork branch May 14, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants