Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add wasm target to release #3056

Closed
wants to merge 2 commits into from
Closed

Conversation

bgwdotdev
Copy link
Contributor

a very slow follow-up to #2433 ^^;

I've added a test/example implementation for the nightly release, should be alright to add roughly the same thing to the release.yaml.

Just wanted to get a clarification on direction generally. If i'm correct it's better to split this out into it's own job as it doesn't fix into the matrix nicely due to the change in build process but if you have recommendations, preferences, whatever, let me know, happy to fit the implementation as required.

example of the build can be found here:
https://github.com/bgwdotdev/gleam/actions/runs/8869952879/job/24351188803

with the associated files here:
https://github.com/bgwdotdev/gleam/releases/tag/nightly

@lpil
Copy link
Member

lpil commented Apr 30, 2024

Hello! Do you have a use-case for a wasm nightly build? We do want it for the regular releases but I'm not aware of folks wanting it for nightly.

@bgwdotdev
Copy link
Contributor Author

oh right! just assumed you'd want it for both and started with the nightly, can shift this over to the release only in that case if that sounds good?

@lpil
Copy link
Member

lpil commented May 1, 2024

That would be fab, thank you 💜

@lpil
Copy link
Member

lpil commented May 20, 2024

Closing due to inactivity. Please feel free to reopen! Thank you

@lpil lpil closed this May 20, 2024
@bgwdotdev
Copy link
Contributor Author

Hey! Sorry for the delay, moved everything and just finished testing the changes, viewable here on my test release

https://github.com/bgwdotdev/gleam/releases/tag/vx.y.z

gleam-vx.y.z-browser.tar.gz

don't seem to have permissions to reopen this PR myself, let me know if I'm better opening a new one?

@lpil
Copy link
Member

lpil commented May 29, 2024

It won't let me open it either for some reason. Could you open a new one please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants