refactor: Split monolithic language files into dirs with component files #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup! fix enum values
fixup! add all missing accessibility modifiers fixup! add all missing accessibility modifiers
fixup! fix any types fixup! fix any types
inferrinizzard
force-pushed
the
refactor/imports/languages
branch
from
b6a8b0b
to
a2462e8
Compare
dvdsgl
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splits up singular files for each language into dirs with the following structure:
language.tsfor options and the exported_TargetLanguageclass_Renderer.tsfor the various renderer(s) that perform the main logicutils.tsfor help functions, ie. namingconstants.tsfor large chunks of static stringsMotivation and Context
This change helps to break down these previously huge files into smaller chunks that are easier to isolate and grok while working on a particular language.
Additionally help to improve performance for linting and formatting threads.
C++ and CJSON are still very large so could use additional refactor work there
Previous Behaviour / Output
Before:
New Behaviour / Output
After:
How Has This Been Tested?
Builds and tests still pass 👍
Screenshots (if appropriate):