-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate AWS SDK for JavaScript v2 APIs to v3 #234
base: main
Are you sure you want to change the base?
Conversation
@trivikr is attempting to deploy a commit to the databerry Team on Vercel. A member of the Team first needs to authorize it. |
@trivikr there's other files where we call s3.(...).promise(), are those calls still compatible with v3 ? // e.g. apps/dashboard/pages/api/datasources/index.ts
await s3.putObject(params).promise(); |
Thanks for the catch. The codemod missed transforming these files, as the type of the client is I'll verify those usages, and manually remove |
61ec165
to
bcc6620
Compare
e624e55
to
00321a7
Compare
c38c7e4
to
d0147c7
Compare
71b3d72
to
5ac7081
Compare
bcc6620
to
e1c80aa
Compare
@gmpetrov I rebase changes since last three months, and also migrated JS SDK v2 APIs in newly introduced webhook. Are there any other changes needed to test this change in CI, and merge? |
AWS SDK for JavaScript v2 will enter maintenance mode on September 8, 2024 and reach end-of-support on September 8, 2025. For more information, check blog post at https://a.co/cUPnyil |
Issue
From AWS SDK for JavaScript v2 README:
Description
This PR migrates AWS SDK for JavaScript v2 APIs to v3 using aws-sdk-js-codemod.
$ npx aws-sdk-js-codemod@0.26.2 -t v2-to-v3 packages/lib/aws.ts