Multi-language Capability #331
Conversation
|
@JanikHalder is attempting to deploy a commit to the databerry Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @morgendigital, support for i18n would be great! |
|
That sounds great @gmpetrov - thank you. We will prepare a test setup over the next couple of days and will get back to you. |
|
@gmpetrov have you checked our recent implementation that we would have liked to commit in the first place? Is there any feedback you can give us here already? Then we can improve it in the test implementation you proposed. Thank you :) |
Hello @morgendigital we're going to check ASAP @OdapX can you review this PR pls? |
|
Thanks, both of you. Just let us know if there's something you'd like to adapt, we will quickly implement it and draft a new round. |
| @@ -36,7 +36,7 @@ COPY turbo.json turbo.json | |||
| # Uncomment the following line in case you want to disable telemetry during the build. | |||
| ENV NEXT_TELEMETRY_DISABLED 1 | |||
| # RUN mv next.config.docker.js next.config.js | |||
| # RUN npm run prisma:generate | |||
| # RUN npm run prisma:generateBzw. | |||
| title="Deploy" | ||
| description="Deploy your agent with the following widgets or integrations" | ||
| title={t('publish')} | ||
| description={t('publish-subtitle')} |
There was a problem hiding this comment.
use camelcase, applies elsewhere too.
|
|
||
| <FormControl> | ||
| <FormLabel>Knowledge Restriction</FormLabel> | ||
| <FormLabel>{t('knowRest')}</FormLabel> |
There was a problem hiding this comment.
please be as explicit as possible with the keys. (knowledgeRestriction)
| @@ -110,7 +112,7 @@ export default function BaseForm(props: Props) { | |||
| {networkError && <Alert color="danger">{networkError}</Alert>} | |||
|
|
|||
| <Input | |||
| label="Datastore Name" | |||
| label={t('nameKonfig')} | |||
| @@ -75,13 +77,13 @@ function EmailInboxSettingsTab({ inboxId }: Props) { | |||
| } | |||
| }, | |||
| color: 'danger', | |||
| children: 'Delete', | |||
| children: `${t('deleteCta')}`, | |||
There was a problem hiding this comment.
should not be structured this way. ctas should be a nested object where relevant.
| icon: <ManageAccountsRoundedIcon fontSize="small" />, | ||
| active: router.route.startsWith(RouteNames.SETTINGS), | ||
| active: router.route.startsWith(RouteNames.PROFILE), |
|
Hi,
We made this change to solve a Routing Issue which leads to a re-rendering of the whole UI instead of only the necassary parts.
It was linked to https://app.chaindesk.ai/settings/, but this URL only redirects to https://app.chaindesk.ai/settings/profile. By replacing the URL with /settings/profile it is possible to prevent the whole page from reloading.
Best Janik.
… Am 26.02.2024 um 22:44 schrieb yahya benzha ***@***.***>:
@OdapX commented on this pull request.
In apps/dashboard/components/Layout/Navigation.tsx <#331 (comment)>:
> icon: <ManageAccountsRoundedIcon fontSize="small" />,
- active: router.route.startsWith(RouteNames.SETTINGS),
+ active: router.route.startsWith(RouteNames.PROFILE),
why this change?
—
Reply to this email directly, view it on GitHub <#331 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWYUJLCS7XQRWAAOKUWFMELYVT63BAVCNFSM6AAAAABDKQZ5U2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBSGA4TGMBTGM>.
You are receiving this because you were mentioned.
|
|
Hi, thank you for your contribution! I have the following remarks:
I think as @gmpetrov suggested, you could scope this to just one page and no need to change the schema at the moment (use this plugin i18next-browser-languagedetector to detect the locale). thanks. |
|
Thank you @OdapX for your extensive and detailed comment! We are on it! |
We propose an integration of an internationalization library (i18n) to allow the UI of Chaindesk to be used in multiple languages. Translation can easily be done over a JSON file, and a language switcher is included in the settings.
Is there any interest for such a functionality?