Fix issue comment number #30556
Fix issue comment number #30556
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
|
How much work would it be to add a migration that fixes the counts on existing issues? Would probably be a long-running migration on big instances, right? Also, not sure if such a migration would be backportable at all as it would likely skip migration numbers (a design flaw in the migration system). |
Yes, so I don't think the migration is necessary. The number will be corrected when next comment created/updated.
|
|
Yeah it's not really a requirement from me, more like a "nice to have" but likely too complicated with the migration backport to really be justified. |
|
Willing to approve this without migration once you fix the tests :) |
| func CountCommentsBuilder(issueID int64) *builder.Builder { | ||
| return builder.Select("count(*)").From("comment").Where(builder.Eq{ | ||
| "issue_id": issueID, | ||
| }.And(builder.Or( |
There was a problem hiding this comment.
Can this be converted into In?
| @@ -109,7 +109,7 @@ func userStatsCorrectNumRepos(ctx context.Context, id int64) error { | |||
| } | |||
|
|
|||
| func repoStatsCorrectIssueNumComments(ctx context.Context, id int64) error { | |||
| return StatsCorrectSQL(ctx, "UPDATE `issue` SET num_comments=(SELECT COUNT(*) FROM `comment` WHERE issue_id=? AND type=0) WHERE id=?", id) | |||
| return StatsCorrectSQL(ctx, "UPDATE `issue` SET num_comments=(SELECT COUNT(*) FROM `comment` WHERE issue_id=? AND (type=0 or type=22)) WHERE id=?", id) | |||
There was a problem hiding this comment.
type=0 or type=22
use variable instead of number?
Fix #22419