Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Sort repo list on dashboard alphabetically #30772

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 30, 2024

TODO

  • make it a user setting

Before

image

After

image


Sponsored by Kithara Software GmbH

@6543 6543 added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Apr 30, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 30, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/js labels Apr 30, 2024
models/repo/search.go Outdated Show resolved Hide resolved
@6543 6543 changed the title Sort repo list on dashboard Sort repo list on dashboard alphabetically Apr 30, 2024
@@ -76,7 +76,7 @@ const sfc = {
return this.repos.length > 0 && this.repos.length < this.counts[`${this.reposFilter}:${this.archivedFilter}:${this.privateFilter}`];
},
searchURL() {
return `${this.subUrl}/repo/search?sort=updated&order=desc&uid=${this.uid}&team_id=${this.teamId}&q=${this.searchQuery
return `${this.subUrl}/repo/search?sort=alpha&order=asc&uid=${this.uid}&team_id=${this.teamId}&q=${this.searchQuery
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be configurable? Sorting by updated time is helpful to me. I usually work on a fixed number of repos at a time, and having them at the top is helpful. The first few repos sorted alphabetically may not be active.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm also not sure about alphabetic sorting here:
I've gotten used to seeing my current repos there as well on the first page to navigate to them quickly.
I don't think it's a good idea to require alphabetic sorting here by default.

@6543 6543 added the pr/wip This PR is not ready for review label Apr 30, 2024
@6543 6543 changed the title Sort repo list on dashboard alphabetically [WIP] Sort repo list on dashboard alphabetically Apr 30, 2024
@6543
Copy link
Member Author

6543 commented Apr 30, 2024

ok I split out the sort fix into #30784 for now :)

@github-actions github-actions bot removed the modifies/go Pull requests that update Go code label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/js pr/wip This PR is not ready for review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants