Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor post recieve handle function #30798

Closed
wants to merge 3 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented May 1, 2024

The function of post-recieve becomes more and more complicated. This PR extract codes from the big function into several small functions to make it more clear.

Depends on #30805 . And this will not be backport so that why there are two PRs here.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 1, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 1, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 1, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 1, 2024
@lunny lunny marked this pull request as draft May 2, 2024 02:06
@lunny
Copy link
Member Author

lunny commented May 14, 2024

Closed as conflicts and we can start a new one more easier.

@lunny lunny closed this May 14, 2024
@lunny lunny deleted the lunny/refactor_post-receive branch May 14, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants