[Refactor] Unify repo search order by logic #30876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
6543
commented
May 6, 2024
| // SearchOrderByFlatMap is similar to SearchOrderByMap but use human language keywords | ||
| // to decide between asc and desc | ||
| var SearchOrderByFlatMap = map[string]db.SearchOrderBy{ | ||
| "newest": SearchOrderByMap["desc"]["created"], |
There was a problem hiding this comment.
this make it easyer to match human keywords with api options ... but if prefered I could also use the const directly ...
6543
commented
May 6, 2024
github-actions
bot
added
the
modifies/api
6543
commented
May 6, 2024
|
I would say this refactor is ready ;) |
I will review and merge after v1.22 stable is released since it's a refactor PR. |
6543
added a commit
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have repo OrderBy definitions defined in one place and use a single type for OrderBy database options