Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing doer #30914

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing doer #30914

wants to merge 1 commit into from
+168 −164

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented May 9, 2024

Follow #30231

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 9, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 9, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels May 9, 2024
@lunny
Copy link
Member

lunny commented May 9, 2024

Maybe we should use consumer as the parameter. i.e. When generating a webhook, the doer is not equal to the consumer. We should always use nil for webhooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yp05327 @lunny @GiteaBot