Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always load or generate oauth2 jwt secret #30942

Merged
merged 3 commits into from May 14, 2024
Merged

Always load or generate oauth2 jwt secret #30942

merged 3 commits into from May 14, 2024

Conversation

wxiaoguang
Copy link
Contributor

Fix #30923

@wxiaoguang wxiaoguang added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels May 11, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 11, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 11, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 11, 2024
@wxiaoguang wxiaoguang mentioned this pull request May 11, 2024
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 11, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 14, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 14, 2024 13:19
@wxiaoguang wxiaoguang added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 14, 2024
@wxiaoguang wxiaoguang merged commit effb405 into go-gitea:main May 14, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 14, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 14, 2024
@wxiaoguang @GiteaBot
Always load or generate oauth2 jwt secret (go-gitea#30942)
b62eb5d 
Fix go-gitea#30923
@GiteaBot GiteaBot mentioned this pull request May 14, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 14, 2024
lunny pushed a commit that referenced this pull request May 14, 2024
@GiteaBot @wxiaoguang
Always load or generate oauth2 jwt secret (#30942) (#30978)
5b7e54f 
Backport #30942 by @wxiaoguang

 Fix #30923

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang wxiaoguang deleted the fix-general-secret branch May 14, 2024 15:14
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 15, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
21aaf94 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Remove unnecessary double quotes on language file (go-gitea#30977)
  Always load or generate oauth2 jwt secret (go-gitea#30942)
  Filter out duplicate action(activity) items for a repository (go-gitea#30957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

@KN4CK3R KN4CK3R Awaiting requested review from KN4CK3R

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

CSRF validation errors when OAuth is not enabled
4 participants
@wxiaoguang @lunny @silverwind @GiteaBot