Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix association replace non-addressable panic #7012

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SergeiSadov
Copy link

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

While replacing associations using an example from the docs panic occurs.

db.Model(&user).Association("Languages").Replace(Language{Name: "DE"}, languageEN)

image

This PR fixes this issue by asserting if the value addressable and checking for the association error later.

User Case Description

Here is the PR for the playground example: go-gorm/playground#734
This is not the obvious case, but the code should not panic in the case, but invalid value gracefully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant