Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schedule feature and tests #655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schmorrison
Copy link
Contributor

@schmorrison schmorrison commented Oct 17, 2021

Thanks for maintaining this package!

Simple scheduling mechanism to periodically start a Collector's scraping routine. The entire schedule group can be cancelled via StopSchedules or cancelling the Collector.Context. When a stop is executed, all currently running schedules will finish naturally (not at once). Currently, the Collector's registered callbacks are not aware of the scheduleContext cancellation via StopSchedules.

I'm sure you will like me to tweak the implementation here.

@WGH-
Copy link
Collaborator

WGH- commented Jan 28, 2022

This uses public Colly API only, you could do it from your own package just fine, and I'm not yet convinced this is frequent enough use case to be integrated into the main code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants