-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GString::chars
for 4.1
#714
Conversation
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-714 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this!
It would be nice if the API >= 4.1 would deprecate and not remove the old names, with a short explanation like:
Renamed to chars(). No longer checked + unchecked overloads, because Godot 4.1 ensures valid UTF-32.\nFor details, see #714.
(I hope that's actually true, didn't check all angles here)...
You can use #[cfg_attr(..., deprecated(...))]
for this.
e4ea57d
to
f406985
Compare
f406985
to
4aaae81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Only few things left 😉
…ring::chars` for 4.1
4aaae81
to
9bba7b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
This race condition is truly annoying... 🙄 |
Add `GString::chars` for 4.1
Adds
GString::chars
for 4.1 and hidesGString::chars_checked
/GString::chars_unchecked
may close #712