Make godot-cpp installable with cmake config #1418
Open
+83
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because target_link_options was added in v3.13 So this wouldn't build with cmake v3.12 Likewise in CMAKE_CXX_STANDARD only supports value of 17 starting with cmake v3.9 So the test wouldn't build properly with cmake v3.6
AThousandShips
added
enhancement
|
Please open a proposal to track the support and details of this feature, this is pretty specific and we'd need to judge the actual demand |
This is so this library can be used via a package manager The install destination uses CMAKE_INSTALL_ so that package managers can choose the best location for these artifacts godot-cpp-dev is the installed component this is so that if this library is a subproject, the user can install their project without installing this library by specifying the components As BUILD_INTERFACE requires absolute path, this means that GODOT_GDEXTENSION_DIR needs to be an absolute path config filename can either be PascalCase or kebab-case, the latter was chosen to be consistent with the package's name (godot-cpp) string(JSON ...) is only available in cmake v3.19, as it is used to obtain the version, this means that config-version file is only created when using cmake v3.19 or later
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows this library to be installable.
The reason is so that this can be easily installed via a package manager without resorting to patches.
This project uses the standard CMAKE_INSTALL_* variables, so that the package manager can decide where to install the various artifacts of this package.
Also provides:
find_packageFrom a user's perspective they can use this library like so:
Note that the target library's name
godot::cppis the consistent as when used viafind_packageor as a sub-project.