-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize home page #806
Optimize home page #806
Conversation
MichaelJRM
commented
Feb 16, 2024
- Updated tobbi & highlight to the most recent version
- Used the custom highlight download tool to only pick the languages that are currently in use thus reducing the file size
- Removed tobbi & highlight from all pages that do not use it
- Created small plugin to fetch CSS asynchronously
- Fixed header
- Reordered requests to optimize FCP & LCP
Before | After |
---|---|
I'm concerned this could introduce FOUC (flash of unstyled content). If the CSS isn't available yet, the page will be displayed as raw HTML. The rest looks good to me 🙂 |
Yes I somehow didn't realize that before, It was only supposed to be used with CSS that's not critical :D |
Fixed a little bug with the fund button, I think I'm done here 🙂 |
613cae1
to
61612f6
Compare
Fixed all but: "Font selection is also different, causing all fonts to be slightly larger on my Linux setup:"
|
I've tested on mac and windows and the font looks the same, I think the issue was that before this pr it wasn't picking your system font. |
I'm closing this PR as not planned. While the intentions are good, we are not going to be making significant changes to the current pages before we transition to the new site using hugo. Thanks! |